Add support for endpoint filters in minimal APIs #40491
Draft
+529
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Mar 2, 2022
| /// This list is not read-only to premit modifying of existing parameters by filters. | ||
| /// </remarks> | ||
| /// </summary> | ||
| public IList<object?> Parameters { get; } |
There was a problem hiding this comment.
Suggested change
| public IList<object?> Parameters { get; } | |
| public IReadOnlyList<object?> Parameters { get; } |
davidfowl
reviewed
Mar 2, 2022
| /// <returns>The <see cref="RequestDelegateResult"/>.</returns> | ||
| #pragma warning disable RS0026 // Do not add multiple public overloads with optional parameters | ||
| public static RequestDelegateResult Create(Delegate handler, RequestDelegateFactoryOptions? options = null) | ||
| public static RequestDelegateResult Create(Delegate handler, RequestDelegateFactoryOptions? options = null, IEnumerable<IRouteHandlerFilter>? filters = null) |
There was a problem hiding this comment.
Should we make this part of the options instead? We need an API review?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Resolves #37853.
This PR introduces an initial implementation of filters for route handlers in minimal APIs. As follow-ups to this work we want to be able to do the following:
MethodInfoassociated with the handlerRouteHandlerFilterContext.Parametersdefinition to provide details about the parameter type, name, and (possibly) validity