Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore PDM project-wide config #3976

Merged
merged 3 commits into from Mar 29, 2022
Merged

Ignore PDM project-wide config #3976

merged 3 commits into from Mar 29, 2022

Conversation

astrojuanlu
Copy link
Contributor

@astrojuanlu astrojuanlu commented Feb 16, 2022

Reasons for making this change:

Will make it easier for new users of pdm to get the configuration right from the start. Among other reasons (see below), pdm init creates a .pdm.toml storing the absolute path of the Python interpreter, which is machine-dependent and therefore should not be tracked in version control.

Links to documentation supporting these rule changes:

See https://pdm.fming.dev/#use-with-ide

See also pdm-project/pdm#699

Python.gitignore Show resolved Hide resolved
Co-authored-by: Lukasz Sobczuk <sobczuk.lukasz@wp.pl>
Python.gitignore Show resolved Hide resolved
@pypros
Copy link
Contributor

@pypros pypros commented Feb 22, 2022

Hello bdougie

Could you have a look? Could you add some comments or approve it?

Br,
Łukasz

@astrojuanlu
Copy link
Contributor Author

@astrojuanlu astrojuanlu commented Mar 15, 2022

Friendly ping @pypros @bdougie

@pypros
Copy link
Contributor

@pypros pypros commented Mar 27, 2022

How can I help you?

@astrojuanlu
Copy link
Contributor Author

@astrojuanlu astrojuanlu commented Mar 27, 2022

Sorry, I assumed you had write access here.

@pypros
Copy link
Contributor

@pypros pypros commented Mar 27, 2022

No, I found the same problem as you and help in the review.

@bdougie bdougie merged commit d0b80a4 into github:main Mar 29, 2022
@astrojuanlu astrojuanlu deleted the patch-1 branch Mar 29, 2022
@astrojuanlu
Copy link
Contributor Author

@astrojuanlu astrojuanlu commented Apr 9, 2022

@Iceberg-Dev that's an individual commit, please look at the whole diff. This is the reason #3976 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants