Make the timeout for receiving requests from attachment writers configurable #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janl
approved these changes
Mar 7, 2022
nickva
approved these changes
Mar 7, 2022
jcoglan
force-pushed
the
configurable-mp-att-timeout
branch
from
4f06a80
to
8ca5234
Compare
… configurable The code that forwards attachment data to cluster nodes via fabric has a hard-coded timeout of five minutes for nodes to request the data. Making this configurable lets us mitigate the impact of issue apache#3939 [1], which causes requests to block if one of the nodes already has the given attachment and doesn't end up requesting the data for it. [1]: apache#3939
jcoglan
force-pushed
the
configurable-mp-att-timeout
branch
from
8ca5234
to
fdba274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The code that forwards attachment data to cluster nodes via fabric has a
hard-coded timeout of five minutes for nodes to request the data. Making
this configurable lets us mitigate the impact of issue #3939, which
causes requests to block if one of the nodes already has the given
attachment and doesn't end up requesting the data for it.
Related Issues or Pull Requests
PUT /db/docwithmultipart/relatedattachments #3939Checklist
rel/overlay/etc/default.ini