Improve incorrect access policy in s3api example #6482
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
• In put-bucket-notification and put-bucket-notification-configuration, update the "Resource" key in the SNS Access Policy to correctly reflect that it is an SNS topic ARN, not an S3 bucket. • To confirm that this is correct, see https://docs.aws.amazon.com/sns/latest/dg/sns-access-policy-use-cases.html#sns-grant-aws-account-access-to-topic
bdavs3
force-pushed
the
s3api-documentation
branch
from
f4bff47 to
dd17373
Compare
|
@kdaily Yep, I agree. I amended my change. |
|
@kdaily Any movement on this, or other requests? I'm not sure if the force push was too aggressive. As a dev, do you want to preserve all of history no matter what? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Fix the "Resource" key in an SNS Access Policy so that it correctly reflects an SNS topic ARN, not an S3 bucket.
To confirm that this is correct, see the relevant AWS docs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.