Rename disable-dnscache-service-win to bat and minor tweaks #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
changed the title
funilrys
reviewed
Mar 6, 2022
|
Yeah, maybe, but it was wrong. It was using LF line endings.
…On Sun, Mar 6, 2022, 22:00 Nissar Chababy ***@***.***> wrote:
***@***.**** commented on this pull request.
This may be a breaking change for the people who automatically download
the "latest" cmd file - without git.
—
Reply to this email directly, view it on GitHub
<#1912 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNNF3ORLMZDSDGGNFWDU6UFFPANCNFSM5QBPWJ6A>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
To see why I have already explicitly set up CRLF in our .gitattributes/.editorconfig: https://serverfault.com/questions/429594/is-it-safe-to-write-batch-files-with-unix-line-endings So, we could add |
|
I'm going to merge this now. Nissar's @funilrys comment is a good one, I think the remediation path for that appears straightforward, I hope that's true |
|
The thing is that Windows cmd can fail with LF (with cryptic error messages) and this was the fix with the less changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Now it's consistent with the other bat file and .editorconfig/.gitattributes apply to this file too.