Skip to content

/ react-native-starter Template

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcode for navigation icon and remove duplicate styles in Navigator module #61

Open
wants to merge 1 commit into
base: master
from
Open

Remove hardcode for navigation icon and remove duplicate styles in Navigator module #61

wants to merge 1 commit into from

Conversation

@bahung1221
Copy link

@bahung1221 bahung1221 commented Jul 9, 2020 •
edited

Hi there,

The icon of navigations inside the drawer was hardcode to iconHome (here), so I changed it to use the icon of each navigation item instead.
I also make a minor change to remove duplicate styles.

Thank you so much! 😄
@bahung1221
Remove hardcode for navigation icon and remove duplicate styles in Na…
3b5f1d2 
…vigator module
@bahung1221
Copy link
Author

@bahung1221 bahung1221 commented Jul 12, 2020

@guardofparadise , Sorry for bothering you, but could you please help to check this PR? 😄
@HzKharel
HzKharel approved these changes Jul 12, 2020
View changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HzKharel HzKharel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@bahung1221 @HzKharel
You can’t perform that action at this time.