Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Update 03.10-Working-With-Strings.ipynb notebook to use local data dump of last known dump file. #249
Conversation
…ata in data folder as a 30mb gz file) and some handling for breaking changes to pd.read_json in most recent pandas it seems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
It seems like the data used in this notebook (pulled in via curl) has gone away (its just an empty file as their export process broke and they did not have time/resources to fix it).
http://openrecipes.s3.amazonaws.com/recipeitems-latest.json.gz
This issue seems to suggest that last known good dump is still available here: https://s3.amazonaws.com/openrecipes/20170107-061401-recipeitems.json.gz
I have added that gz file to the
datarepo and changed one or two cells to use that instead (also means user on windows don't need thegunzipcli which caused trouble for some students we have using this).I have also added some strange handling i had to do for pd.read_json() relating to pandas 1.1.1 as per this SO using StringIO(). Not quite sure exactly the details here and is a chance this part is a little 'hacky'.
The changes i have made might not quite be what you might do yourself but i just wanted to get this notebook 'working' for a some students we have at Springboard who use this notebook as an exercise in part of the course.
So figured i may aswell make a PR in case useful to you or anyone else.