[BEAM-1754] Adds experimental Typescript Beam SDK #17341
Merged
+41,332
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a bug in the data channel that undefined was masking.
make tests typescript
Starting the proto translation of Impulse, ParDo, GBK
npm WARN old lockfile npm WARN old lockfile The package-lock.json file was created with an old version of npm, npm WARN old lockfile so supplemental metadata must be fetched from the registry. npm WARN old lockfile npm WARN old lockfile This is a one-time fix-up, please be patient... npm WARN old lockfile
Adding transform names and fixing GBK coder issue. Reformatting.
Also add no-pipeline running API. Added simple WordCount example/test.
Create base class, organize file paths and process gradle target/version into JAR names. Includes small unit tests
Add TODOs for later
damccorm
reviewed
Apr 21, 2022
damccorm
reviewed
Apr 26, 2022
damccorm
reviewed
Apr 26, 2022
damccorm
reviewed
Apr 26, 2022
damccorm
reviewed
Apr 26, 2022
sdks/typescript/src/apache_beam/transforms/group_and_combine.ts
Outdated
Show resolved
Hide resolved
damccorm
reviewed
Apr 26, 2022
damccorm
reviewed
Apr 26, 2022
damccorm
reviewed
Apr 26, 2022
damccorm
reviewed
Apr 26, 2022
damccorm
reviewed
Apr 26, 2022
damccorm
reviewed
Apr 26, 2022
damccorm
reviewed
Apr 26, 2022
Co-authored-by: Danny McCormick <dannymccormick@google.com>
robertwb
reviewed
Apr 29, 2022
Thanks for looking over all of this! There are only a few outstanding comments now.
damccorm
reviewed
Apr 29, 2022
Thanks for the changes - this generally looks good to me sans the remaining open items.
damccorm
reviewed
Apr 29, 2022
This looks good to me other than the couple of remaining comments - thanks for making those changes!
Also deleted an unused file.
|
Run Java PreCommit |
|
Run Python PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Overview can be found in included README: https://github.com/robertwb/incubator-beam/blob/javascript/sdks/typescript/README.md
Coordination file for dividing up the review can be found at https://docs.google.com/spreadsheets/d/16nqMaBIIyM3s0wq0eS10e-eqktuS8HYpCRkRDHmAMf8/edit
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.