Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix outgoingMessage.removeHeader() signature #42652

Merged
merged 1 commit into from Apr 10, 2022

Conversation

Copy link
Member

@lpinca lpinca commented Apr 8, 2022

Specify that outgoingMessage.removeHeader() takes a name argument
whose type is string.

@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Apr 8, 2022

Review requested:

@nodejs-github-bot nodejs-github-bot added doc http labels Apr 8, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument
whose type is string.
@lpinca lpinca changed the title doc: add missing argument to function signature doc: fix outgoingMessage.removeHeader() signature Apr 8, 2022
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

LGTM

ronag
ronag approved these changes Apr 8, 2022
Copy link
Member

@mcollina mcollina left a comment

lgtm

@marsonya marsonya added the author ready label Apr 9, 2022
@targos targos added the commit-queue label Apr 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue label Apr 10, 2022
@nodejs-github-bot nodejs-github-bot merged commit 13ad8d4 into nodejs:master Apr 10, 2022
17 checks passed
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Apr 10, 2022

Landed in 13ad8d4

@lpinca lpinca deleted the add/missing-argument branch Apr 10, 2022
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
Specify that `outgoingMessage.removeHeader()` takes a `name` argument
whose type is string.

PR-URL: nodejs#42652
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready doc http
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants