Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix for case sensitivity issue #8 #130
Conversation
Signed-off-by: Someone <someone@somenet.org>
Signed-off-by: Someone <someone@somenet.org>
someone-somenet-org
force-pushed the
someone-somenet-org:patch-1
branch
from
6810e9e
to
f124d90
|
nice idea! thanks! did you have the opportunity to test this? |
| $this->storeUser($uid); | ||
| return $uid; | ||
| return $this->storeUser($uid); |
violoncelloCH
Apr 2, 2020
Member
I guess we would need to add this change to every backend...
I guess we would need to add this change to every backend...
someone-somenet-org
Apr 3, 2020
Author
It should have no direct impact on any other backends, because it returned the uid before and returns the uid after the change too... just slightly diffrent.
It would likely make sense to adapt this change for other backends too, but i currently dont have the resources to do this and test it for all other backend. (I just fixed the problem for our instance. :)
It should have no direct impact on any other backends, because it returned the uid before and returns the uid after the change too... just slightly diffrent.
It would likely make sense to adapt this change for other backends too, but i currently dont have the resources to do this and test it for all other backend. (I just fixed the problem for our instance. :)
violoncelloCH
Apr 10, 2020
Member
okay I see; thank you very much!
okay I see; thank you very much!
No formal testing like writing tests happened. It is/was running fine on our instance/no users reported issues. Unfortunately, due to covid, our activities died down pretty hard, so I am not sure if users started to experience any issues since, or if we are just dead. Noone complained yet. |
|
okay, thanks - that's what I wanted to know :) |
Hopefully fixes #8
There is no way to sign off a commit in the github web-gui.
Also: Please squash the edits and/or "steal" the changes by committing as author = someone of you maintainers.