Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load extensions in the main thread #422

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Load extensions in the main thread #422

merged 1 commit into from
Apr 12, 2022

Conversation

pkasila
Copy link
Member

@pkasila pkasila commented Apr 12, 2022

Description

Quick-fix what was discovered by @nanashili in Discord#bugs.

Now extensions are preloaded in the main thread instead of separate one. So, it won't cause any issues.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

@pkasila pkasila added bug Something isn't working extensions Issues related to the extension architecture in CodeEdit labels Apr 12, 2022
@pkasila pkasila requested a review from nanashili April 12, 2022 12:19
@pkasila pkasila merged commit 30f6ca6 into CodeEditApp:main Apr 12, 2022
@pkasila pkasila deleted the extensions-api branch April 12, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukepistrol lukepistrol lukepistrol approved these changes

@nanashili nanashili Awaiting requested review from nanashili

Assignees
No one assigned
Labels
bug Something isn't working extensions Issues related to the extension architecture in CodeEdit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkasila @lukepistrol