Added functionality to close welcome screen when file is selected #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukepistrol
requested changes
Apr 12, 2022
CodeEdit/AppDelegate.swift
Outdated
| } else { | ||
| CodeEditDocumentController.shared.openDocument { _, _ in | ||
| } | ||
| else { |
Member
There was a problem hiding this comment.
move the else statement to the previous line:
if ... {
...
} else {
…
}having it on a new line fails in SwiftLint
|
|
||
| extension NSDocumentController { | ||
| func openDocument(completionHandler: @escaping (NSDocument?, Bool) -> Void) { | ||
| func openDocument(completionHandler: @escaping (NSDocument?, Bool) -> Void, cancelHandler: @escaping () -> Void) { |
Member
There was a problem hiding this comment.
Instead of
func openDocument(completionHandler: @escaping (NSDocument?, Bool) -> Void, cancelHandler: @escaping () -> Void) {}consider using a blank or onCompletion label for the first argument and onCancel for the second one.
func openDocument(_ completionHandler: @escaping (NSDocument?, Bool) -> Void, onCancel: @escaping () -> Void) {}
lukepistrol
approved these changes
Apr 12, 2022
Contributor
Author
|
Many thanks 👍 @lukepistrol |
Collaborator
|
@all-contributors please add @dzign1 for code |
Contributor
|
I've put up a pull request to add @dzign1! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Welcome screen now disappears when the 'Open a file or folder' is pressed. This is done by adding a cancel handler parameter to the openDocument function which calls the openWelcome function once cancel is pressed.
Related Issue
Checklist
Screenshots