Skip to content
#

openshift

Here are 2,066 public repositories matching this topic...

jx
ankitm123
ankitm123 commented Jan 5, 2022

Not sure what the error is, but lint passes in the CI and locally even if exported structs dont have comments.
Most probably, it's an issue with the golangci yaml config we use.

Also we use revive instead of golint (which is deprecated), may be some setting in revive needs to be enabled?

If we check the goreport card, we can see the issues: https://goreportcard.com/report/github.com/jenkins

help wanted good first issue area/quality
juazugas
juazugas commented Mar 24, 2022

In the README file the link points to the file ocp-injected-certs.yaml but the filename is ocp-injected-certs.yml (the extension name is different). I could suggest the PR for changing the README.md but since all the files have the four-letter extension, I think it makes more sense to rename the targeted file.

https://github.com/grafana-operator/grafana-operator/blob/aa20ca09dbcc755059c25c5

good first issue triage/accepted
Troyhy
Troyhy commented Feb 25, 2022

It would be good to add a mention about healthEndpoint to documentation as it is super useful when using urlFrom.ingressRef

At least I could not easily find the complete list of supported values. Luckily found a mention in https://github.com/stakater/IngressMonitorController/blob/master/docs/migration-guide.md

It is not the first doc to read as I started using the operator from the start.

good first issue kind/documentation

Improve this page

Add a description, image, and links to the openshift topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the openshift topic, visit your repo's landing page and select "manage topics."

Learn more