Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Java package from Github actions #1340

Merged
merged 14 commits into from
May 12, 2022

Conversation

pakrym-stripe
Copy link
Contributor

@pakrym-stripe pakrym-stripe commented Apr 14, 2022

Adds steps to release Java package and JavaDoc on tag pushes.

@pakrym-stripe pakrym-stripe changed the title Publish Java package from Github actions @pakrym-stripe Publish Java package from Github actions Apr 14, 2022
@pakrym-stripe pakrym-stripe marked this pull request as ready for review May 12, 2022 17:43
Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes and then looks good to me! Once we're migrated to this we'll no longer have an asset tied to the GH release right?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@pakrym-stripe
Copy link
Contributor Author

PTAL @dcr-stripe ?

Copy link
Contributor

@dcr-stripe dcr-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pakrym-stripe pakrym-stripe merged commit fff01da into master May 12, 2022
@richardm-stripe richardm-stripe deleted the pakrym/Publish_Java_package_from_Github_actions branch October 14, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants