Skip to content
#

vitess

Here are 20 public repositories matching this topic...

systay
systay commented Apr 20, 2022

Our parser outputs all aggregations functions using the general sqlparser.FuncExpr. This is a little clunky and requires us to do additional checks before we are sure that the aggregation we have is valid and what it is aggregating.

I suggest we instead introduce one struct type per aggregation, and have them all implement some interface. This would help clean up the code.

Example:

Improve this page

Add a description, image, and links to the vitess topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the vitess topic, visit your repo's landing page and select "manage topics."

Learn more