Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nuxi): manage modules via cli #4001

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(nuxi): manage modules via cli #4001

wants to merge 6 commits into from
+164 −5

Conversation

Intevel
Copy link

@Intevel Intevel commented Mar 31, 2022 •
edited

🔗 Linked issue

nuxt/rfcs#31
#569
#3915

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

With the new commands you can now add different Nuxt 3 modules (& bridge) to the project via Nuxi. The given module name is matched with a list that is currently still done manually (maybe in the future an API?), the name is matched to prevent that not Nuxt modules are installed. The module is added to the .nuxtrc file which is merged with the normal nuxt config.

carbon

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

@netlify netlify bot commented Mar 31, 2022 •
edited

❌ Deploy Preview for nuxt3-docs failed.

Name Link
🔨 Latest commit 5662e4d
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62460e13df9090000808bc42

@Intevel Intevel marked this pull request as draft Mar 31, 2022
@Intevel Intevel marked this pull request as ready for review Mar 31, 2022
@Intevel
Copy link
Author

@Intevel Intevel commented Mar 31, 2022

@Baroshem

@pi0
Copy link
Member

@pi0 pi0 commented Mar 31, 2022

Thanks for the PR @Intevel. Some notes:

  • Please disable local linter (prettier) and run yarn lint --fix
  • We can start with nuxi module add <npm name> syntax (later integrate with nuxt modules DB but is not straight forward)
  • lmify is deprecated. Working on a new package. It is not safe to rely on.

@pi0 pi0 marked this pull request as draft Mar 31, 2022
@pi0 pi0 added the pending label Mar 31, 2022
@Intevel
Copy link
Author

@Intevel Intevel commented Mar 31, 2022

Thank you @pi0.
I had already talked with @Atinux that we draft this PR for now. I fixed the linting & disabled prettier. Currently have some kind of manual DB inserted with names, similar to slugs. That would be just an idea.

@Intevel Intevel mentioned this pull request Mar 31, 2022
Draft
10 tasks
Baroshem
Baroshem reviewed Mar 31, 2022
View changes
packages/nuxi/src/commands/module.ts Outdated Show resolved Hide resolved
packages/nuxi/src/utils/modules.ts Outdated Show resolved Hide resolved
packages/nuxi/src/utils/modules.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baroshem Baroshem

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Intevel @pi0 @Baroshem