Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: refactor lint-sh.js to esm module #42942

Merged
merged 3 commits into from May 8, 2022

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented May 2, 2022

This pr refactor lint-sh.js to esm module

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 2, 2022

Review requested:

@nodejs-github-bot nodejs-github-bot added meta tools labels May 2, 2022
@F3n67u F3n67u marked this pull request as ready for review May 2, 2022
tools/lint-sh.mjs Outdated Show resolved Hide resolved
tools/lint-sh.mjs Outdated Show resolved Hide resolved
F3n67u and others added 2 commits May 3, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
aduh95 approved these changes May 3, 2022
@aduh95 aduh95 added author ready commit-queue-squash labels May 3, 2022
@RaisinTen RaisinTen added the commit-queue label May 8, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue label May 8, 2022
@nodejs-github-bot nodejs-github-bot merged commit be1ca70 into nodejs:master May 8, 2022
25 checks passed
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 8, 2022

Landed in be1ca70

@F3n67u F3n67u deleted the esm/lint-sh branch May 8, 2022
RafaelGSS pushed a commit that referenced this issue May 10, 2022
PR-URL: #42942
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready commit-queue-squash meta tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants