dapp

Component

Forge

Describe the feature you would like

Currently vm.expectCall operates on a target address and the calldata it expects

 function expectCall(address,bytes calldata) external;

When sending ETH through multiple contracts, it would be useful to have an overloaded expectCall that also accepts a value param that also asserts on call context's value

deploying libraries can take a long time. One can easily skip this stage if we make it possible to save the deployed library state and pass it to dapp test:

1. Write a new little dapp helper script which is the dapp --library-addresses above
2. Make dapp build and dapp --make-library-state use this helper script instead
3. Allow a flag --state to be passed to dapp test (probably a

We should apply sorting to the list of installed apps in the App Center (we "randomize" the discovery page to make it a bit more "fun"):

1. Upgrades available ahead of up to date apps
2. Alphabetical

cc @bpierre @dizzypaty I've also been wondering if it might be nice to start having sections in the App Center similar to Voting, for the different classes of apps (e.g. "ready" vs. "experiment

Some file is importing something from some test file. This means that we have to include the test directory in the published package, but besides that it's just a bad idea. I haven't looked into it, but it's probably easy to fix.

walletconnect always goes to rinkeby...

<UseWalletProvider
chainId={3}
connectors={{
walletconnect: {
rpcUrl:
'https://ropsten.infura.io/v3/7082b757ec2e4ebd8d47ca9518743623',
},
}}
>
...

onConnect={() => connect('walletconnect')}

But...

Response :
POST https://rinkeby.infura.io/v3/ 401 (Unauthorized

Go through and fix all tests that do this and ensure that the tests pass afterwards.

TODOs:

• check that all uses of assertRevert are not using the optional errorMessage param as the expected revert reason; if so, change assertRevert -> assertRevertWithReason
  • Examples:
    • packages/protocol/test/governance/validators/downtimeslasher.ts numerous, including L241
    • `packa