Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from a text-based to an XML-based output representation #293

Open
ennioVisco opened this issue Mar 3, 2017 · 3 comments
Open

Moving from a text-based to an XML-based output representation #293

ennioVisco opened this issue Mar 3, 2017 · 3 comments

Comments

@ennioVisco
Copy link
Member

@ennioVisco ennioVisco commented Mar 3, 2017

Hi all,

since I wanted to work on the topic discussed on Trinitycore - Tool for Scripters/DB devs , I think that a first preparation step needed is to format the output in a more efficient and machine-readable way.

XML seems to be a good candidate since it is tree based (and therefore efficiently explorable) and can be compressed really well (ever heard about EXI)?

I'm doing some experiments on my fork, any ideas about this?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@DDuarte
Copy link
Member

@DDuarte DDuarte commented Mar 3, 2017

I would agree with XML, if we were in 2005. I prefer JSON by a large margin.

However, we do not need to commit to a single output format, we can support both output writers, that use the same intermediate format.

binary PKT -> intermediate format -> output (text, xml, json, etc.)

I'm happy do discuss this so drop by the IRC some time :)

@ennioVisco
Copy link
Member Author

@ennioVisco ennioVisco commented Mar 4, 2017

Clearly my idea was not to bound the output to xml but to properly abstract it.
Btw XML and JSON are not just two equivalent alternatives.... JSON is way better for data transfer but not that good for languages description, it is not just a metter of syntax :)

I'll be glad to discuss about it on IRC :)

@DDuarte
Copy link
Member

@DDuarte DDuarte commented Mar 12, 2017

First part: moving handlers to proper structs/classes https://github.com/TrinityCore/WowPacketParser/tree/handlers_refactor

Second part: Serialization of structs to other formats #296

@ennioVisco ennioVisco mentioned this issue Sep 27, 2017
6 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.