Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look up localized templates in the same way Rails does #1348

Open
denkozlovs opened this issue May 6, 2022 · 3 comments
Open

Look up localized templates in the same way Rails does #1348

denkozlovs opened this issue May 6, 2022 · 3 comments
Labels
help wanted v3

Comments

@denkozlovs
Copy link

@denkozlovs denkozlovs commented May 6, 2022

Feature request

Support I18n templates finding

Motivation

When i'm using views, i'm able to create:

  • show.en.html.erb
  • show.de.html.erb

With ViewComponent i'm forced to use a workaround:

  • some_component.html+en.erb
  • some_component.html+de.erb

Version 3 removes with_variant support, so i cannot upgrade

@isaeviv
Copy link

@isaeviv isaeviv commented May 6, 2022

@boardfish boardfish changed the title I18n support Look up localized templates in the same way Rails does May 6, 2022
@boardfish
Copy link
Collaborator

@boardfish boardfish commented May 6, 2022

Hi @denkozlovs and @isaeviv! The move to deprecate and remove with_variant seems to have revealed a lot of folks who continue to depend on it, and this was already something that diverged from Rails slightly. Maybe this can be (re)introduced as a feature, especially if it's holding you back from upgrading.

@elia, would you be interested in picking this up?

@elia
Copy link
Collaborator

@elia elia commented May 6, 2022

Alas I can't pick this up right now, and I'm not sure about when I'll have time.
Anyway if I eventually pick this up I'll update this issue before starting to work on it 👍

@joelhawksley joelhawksley added help wanted v3 labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted v3
Projects
None yet
Development

No branches or pull requests

5 participants