cryptography

Following the merge of bitcoin/bitcoin#23083, we'll throw a non-fatal error at runtime if the documentation for an RPC is incorrect. This behaviour has found numerous issues over a very short period (of the PR being opened). However, this is not something that we want in production / release builds, instead, we want the ability to have it enabled in the CI and when running

The documentation for X509_NAME_print says:

X509_NAME_print() prints out name to bp indenting each line by obase characters. Multiple lines are used if the output (including indent) exceeds 80 characters.
https://github.com/openssl/openssl/blob/master/doc/man3/X509_NAME_print_ex.pod

However, the implementation does not actually do this. obase and 80 figure into l, but l is decreme

Please agree to the following

• I have searched existing issues for duplicates
• I agree to follow this project's Code of Conduct

Summary

Add notificaiton marker to tray menu, if notification is present in main app

Motivation

A user

Background

Inspired by C-Otto/rebalance-lnd#241.

As part of pathfinding, lnd might encounter edges that have a policy specifying a zero CLTV delta (possibly because of no/outdated gossip?). Every time an edge like this is used in the pathfinding code, a warning is logged: https://github.com/lightningnetwork/lnd/blob/290b78e700021e238f7e6bdce6acc80de8d0a64f/routi

Currently stratumserver has no unit tests. This will improve the quality and allow future commits to be TDD safe. All units will be tested to ensure the module as a unit itself is tested.

Issue Description

The instructions provided on failed jobs (example) don't clearly explain where to find the generated patch file. This can be a problem for anyone who is not familiar with how Github Actions pages are organized.

The general idea is:

From the details page, click on "Summary", then scroll down to the "Artifacts" secti

Problem:

A common pattern is:

GUARD(s2n_stuffer_skip_write(stuffer, bytes_to_write));
uint8_t* ptr = suffer->blob.data + stuffer->write_cursor - bytes_to_write;

which could be simplified.

Solution:

*ptr could be an *out parameter to s2n_stuffer_skip_write

• Does this change what S2N sends over the wire? No.
• Does this change any public APIs? No.

The mail option does not have a subject. It would be nice to have a customizable subject.

<a href="mailto:someone@yoursite.com?subject=themailsubjecthere">Email Us</a>