Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Experimental per-header edit on github #4

Open
wants to merge 2 commits into
base: master
from

Conversation

@mitsuhiko
Copy link
Member

@mitsuhiko mitsuhiko commented May 3, 2020

Not sure if a good idea or not. I played around with this because I was hoping to get some comment leaving going. One could change this to open a new github issue pre-filled with the link to the source range added.

Eg, it could prefill a comment that links to something like this:

## Rules on Dependencies
1. Any new dependency needs to be thoroughly reviewed and whitelisted
2. Dependencies must be range pinned semver conforming in the requirements file of sentry
3. Dependencies **must** be hard pinned in getsentry
There is currently no system in place to verify pins so be super careful when working with dependencies or reviewing dependency changes of others.

@vercel
Copy link

@vercel vercel bot commented May 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/develop/idiugp1du/sentry.dev
Preview: https://develop-git-feature-edit-header-on-github.sentry.dev

@mitsuhiko mitsuhiko force-pushed the feature/edit-header-on-github branch from dec4e34 to eadb254 May 4, 2020
@dcramer
Copy link
Member

@dcramer dcramer commented May 4, 2020

We chatted in Slack, but we should probably put permalink + edit on the same line post-header (vs split). That might be a bit tricky implementation-wise though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.