window_editor_object_selection_select_object currently returns its success through a bool and also the global gGameCommandErrorText. It should be refactored to return a GameAction::Result to remove the use of the global.

Is your feature request related to a problem? Please describe.

As somebody who lives in Texas I don't know much about sassafras trees, but from my research they are native to NE and surrounding areas if somebody lives in areas with these trees feel free to correct me. "A deciduous tree (or shrub) native to North America, growing sassafras trees can grow to 30 to 60 feet tall by 25 to 40 fe

What could be improved

Based on this issue: flame-engine/flame#954, I noticed that we could also go for the same approach for the packages' unit/widget tests execution,

Only the host is able to pick up the gray suit (and probably the brown one as well). Other players are able to see it, but the item will vanish if they attempt to pick it up.

Is probably caused by SpawnQuestItem() not syncing the item with the client, this also affects the Torn Notes and most single player quests. The solution should be similar to what was done in https://github.com/diasurgical

Version of OpenTTD

Since e04ca904a9455afc63aa87db775fe4463ab899b7

The introduction of the minimap screenshot feature appears to be duplicating functionality that will be used elsewhere for drawing the widgets within the minimap window; specifically, the GetMinimapOwner function is very likely to be replicating functionality used by the owner information overlay of the minimap window.

As the subject says, since right now it's pretty much impossible to find out the id of an add-on without downloading it, or changing log levels and then interacting with it in some specific way other than looking at its info on the UI.

(Perhaps hide them behind debug mode?)

I think there's an extra #endif in tinyfiles.h. Around line 88 there's this:

#if defined( TINYPATH_IMPLEMENTATION )
#endif TINYPATH_IMPLEMENTATION

That #endif doesn't look like it should be there. I get compilation errors about the final #endif having no matching #if

Motivation

Dependency injection via @In is a widely used mechanism throughout our code-base.
However, it doesn't seem to be supported for all kinds of classes yet.

While it is implemented for world generators, it is not yet implemented for world-gen plugins.
If used for these, it can/will lead to NPEs due to fields not being properly initialized before being accessed.

Example

User Story

If a large download fails using curl it does not cause a fatal error instead it simply carries on.

Basic info

• Command: Install

Further Information

It is worth checking how all downloads handle when failing to ensure they cause a fatal exit.

To Reproduce

Use a game server that is non-steam and cause the download to fail

Expected behaviour

Describe the issue

I don't know exactly in what conditions, but it happens in any level at any random moment, that sometimes, you cure people in the hospital but this is not reflected in money earnings.

This is very noticeable when you are out of money and cure a patient. You can listen the "celebration voices" but money is not incremented.

Steps to Reproduce

1. Start a game and