Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve information collected by the Python: Report Issue command #19068

Merged
merged 4 commits into from May 5, 2022
Merged

Improve information collected by the Python: Report Issue command #19068

merged 4 commits into from May 5, 2022

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented May 5, 2022

Closes #19067

@karrtikr karrtikr added the skip package*.json label May 5, 2022
@karrtikr karrtikr marked this pull request as ready for review May 5, 2022
karrtikr
karrtikr reviewed May 5, 2022
View changes
src/test/common/application/commands/issueTemplateVenv1.md
experiments
• enabled: true
• enabled: false
• optInto: []
• optOutFrom: []
venvPath: "<placeholder>"
pipenvPath: "<placeholder>"
Copy link
Author

@karrtikr karrtikr May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old way.

src/test/common/application/commands/issueTemplateVenv2.md
<summary>User Settings</summary>

<p>

```
Multiroot scenario, following user settings may not apply:
experiments
• enabled: false
venvPath: "<placeholder>"
Copy link
Author

@karrtikr karrtikr May 5, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New behavior.

@karrtikr karrtikr merged commit e23801f into microsoft:main May 5, 2022
25 checks passed
@karrtikr karrtikr deleted the addcom branch May 5, 2022
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this issue May 10, 2022
@karrtikr @karthiknadig
Improve information collected by the Python: Report Issue command (m…
b97000e 
…icrosoft#19068)

* Improve information collected by the `Python: Report Issue` command

* Fix package.json

* Add test

* Add test for multiroot
karthiknadig pushed a commit that referenced this issue May 10, 2022
@karrtikr @karthiknadig
Improve information collected by the Python: Report Issue command (#…
259dbd5 
…19068)

* Improve information collected by the `Python: Report Issue` command

* Fix package.json

* Add test

* Add test for multiroot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimadeline kimadeline

@paulacamargo25 paulacamargo25

Assignees

@karrtikr karrtikr

Labels
skip package*.json
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve information collected by the Python: Report Issue command
2 participants
@karrtikr @kimadeline