Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): IonTabButton will call custom onClick handlers #25313

Merged
merged 5 commits into from May 19, 2022
Merged

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented May 18, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Any custom onClick handlers applied to IonTabButton are ignored.

Issue URL: #22511

What is the new behavior?

  • IonTabButton will allow custom onClick handlers

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 6.1.7-dev.11652903163.152ffc14 馃煥

@sean-perkins sean-perkins requested a review from as a code owner May 18, 2022
@github-actions github-actions bot added the package: react label May 18, 2022
Copy link
Contributor

@amandaejohnston amandaejohnston left a comment

Tested with a fresh starter app, works on my end 馃憤

@sean-perkins sean-perkins merged commit 6034418 into main May 19, 2022
37 checks passed
@sean-perkins sean-perkins deleted the FW-1181 branch May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants