Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xcode style toolbar background issue. #587

Merged
merged 3 commits into from
May 3, 2022
Merged

Fix Xcode style toolbar background issue. #587

merged 3 commits into from
May 3, 2022

Conversation

lilingxi01
Copy link
Member

@lilingxi01 lilingxi01 commented May 3, 2022 •
edited
Loading

Description

  • Fix the xcode toolbar background issue in fullscreen mode. Use the same material now.
  • Keep the behavior in native tab style.

Related Issue

This PR is resolving the problem in the followup of this issue.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

image

image

@pkasila pkasila merged commit f6f4b5c into CodeEditApp:main May 3, 2022
@lilingxi01 lilingxi01 deleted the tab-bar-xcode-fix branch May 3, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xWDG 0xWDG 0xWDG approved these changes

@lukepistrol lukepistrol lukepistrol approved these changes

@pkasila pkasila pkasila approved these changes

@nanashili nanashili Awaiting requested review from nanashili

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lilingxi01 @0xWDG @lukepistrol @pkasila