Update guide sidebar to contain all guides #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortent
requested review from
bgrant0607,
droot,
justinsb,
mengqiy,
martinmaly,
natasha41575 and
yuwenma
as code owners
martinmaly
approved these changes
May 13, 2022
droot
reviewed
May 13, 2022
site/guides/README.md
Outdated
| - [Porch User Guide](guides/porch-user-guide.md) | ||
| - [Namespace Provisioning CLI](guides/namespace-provisioning-cli.md) | ||
| - [Namespace Provisioning UI](guides/namespace-provisioning-ui.md) | ||
| - [Tenant Onboarding Guide](guides/tenant-onboarding.md) |
There was a problem hiding this comment.
Removing this from the navigation was intentional because namespace provisioning CLI guide covers this use-case. I kept the old guide around to avoid breaking the old links (may be removing the guide will be the right thing to avoid the confusion).
There was a problem hiding this comment.
Removed the links to the Tenant Onboarding Guide from both the sidebar and the guides landing page.
droot
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This addresses a few issues with the kpt.dev site:
docs/sync/prototyp-controller.md