fix(nvim.js): $NVIM_LISTEN_ADDRESS is deprecated #195
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging cfdeb40 into 6ce0475 - view on LGTM.com new alerts:
|
|
I'll wait to merge this until it can run against Nvim nightly with the upstream change. |
Use $NVIM with Nvim 0.8+. Since neovim/neovim#11009 (Nvim 0.8+) Nvim does _not_ pass $NVIM_LISTEN_ADDRESS to child processes. The correct way to detect a "host" or "parent" Nvim is to check for $NVIM env var: this means the current process is a child of Nvim. The old $NVIM_LISTEN_ADDRESS env var had conflicting purposes as both a parameter ("the current process should _listen on_ this address") and a descriptor ("the current process is a _child of_ this address").
rhysd
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Use $NVIM with Nvim 0.8+.
neovim/neovim#11009 (Nvim 0.8+) will change Nvim so that $NVIM_LISTEN_ADDRESS is not passed to child processes. After that, the correct way to detect a "host" or "parent" Nvim is to check for $NVIM env var: this means the current process is a child of Nvim.
The old $NVIM_LISTEN_ADDRESS env var had conflicting purposes as both a parameter ("the current process should listen on this address") and a descriptor ("the current process is a child of this address").