Skip to content

/ PSScriptAnalyzer

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Fix Remove empty catch block. #985

Open
wants to merge 8 commits into
base: development
from
Open

WIP Fix Remove empty catch block. #985

wants to merge 8 commits into from

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented May 5, 2018 •
edited

PR Summary

An empty catch block was found in the code and was removed as I cannot see a reason for an exception and if so I would rather like to see a future bug report.
Since the fix was so simple, I was not sure if it is really worth having a test for it?

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • NA User facing documentation needed
  • Change is not breaking
  • Make sure you've added a new test if existing tests do not effectively test the code changed => I'm not sure if it is really worth having a test for that since the code fix was quite simple.
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready
@bergmeister
Fix NullReferenceException when CimSuperClass is null and remove empt…
Loading status checks…
e213d45 
…y catch block.
@bergmeister bergmeister self-assigned this May 5, 2018
bergmeister added 2 commits May 7, 2018
@bergmeister
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
Loading status checks…
627b62a 
…nalyzer into useIdenticalMandatoryParamsFix
@bergmeister
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
Loading status checks…
1a4991f 
…nalyzer into useIdenticalMandatoryParamsFix
@bergmeister bergmeister changed the title Fix NullReferenceException when CimSuperClass is null and remove empty catch block. WIP Fix NullReferenceException when CimSuperClass is null and remove empty catch block. May 11, 2018
@edyoung edyoung mentioned this pull request Jul 26, 2018
Merged
5 of 7 tasks complete
bergmeister added 3 commits Jul 26, 2018
@bergmeister
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
Loading status checks…
fc7fb7c 
…nalyzer into useIdenticalMandatoryParamsFix
@bergmeister
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
Loading status checks…
31b2767 
…nalyzer into useIdenticalMandatoryParamsFix
@bergmeister
Merge with branch development and fix conflicts
Loading status checks…
d191ede
@bergmeister bergmeister changed the title WIP Fix NullReferenceException when CimSuperClass is null and remove empty catch block. WIP Fix Remove empty catch block. Oct 3, 2018
bergmeister added 2 commits Jan 9, 2019
@bergmeister
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
Loading status checks…
39df6b5 
…nalyzer into useIdenticalMandatoryParamsFix
@bergmeister
Merge branch 'development' of https://github.com/PowerShell/PSScriptA…
Loading status checks…
32c153a 
…nalyzer into useIdenticalMandatoryParamsFix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bergmeister bergmeister

Labels
Area - Rules Issue - Bug
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@bergmeister
You can’t perform that action at this time.