samrose3
Follow
samrose3
Follow
Achievements
Achievements
Highlights
- 3 discussions answered
Pinned
776 contributions in the last year
Contribution activity
May 2022
Created 22 commits in 1 repository
Created a pull request in Shopify/polaris that received 5 comments
Remove TS project references and type check
WHY are these changes introduced? Fixes #5792 WHAT is this pull request doing? Remove TS project references for the following reasons: the .tsbu…
+18
−7
•
5
comments
Opened 25 other pull requests in 3 repositories
Shopify/polaris
20
merged
3
open
- Fix prerelease check boolean
- Check if prelease mode is already enabled before entering
- Ignore changelog check for changeset PRs
- Fix Prerelease workflow name
- Update Releasing.md with release and prerelease info
- Remove changelog check on Changesets release PRs
- Add @changesets/changelog-github as a dependency
- Add initial changesets
- Update CI trigger branches to prevent running twice
- Make Polaris for VS Code and Figma private to prevent publishing
- Add workflow for creating a prerelease
- Remove shipit
- Add @markdoc/next.js to test rendering Markdown in Next.js site
- Use glob path for ESLint parser options project tsconfig
- Add Changesets and GitHub Actions release workflow
-
Clean
tsbuildinfoand add common scripts topolaris-for-figma - Replace yarn workspace commands with turbo equivalent
- Cache the Next.js site build in CI
- Replace Yarn with pnpm as package manager
- Clean up tsconfigs to use shared @shopify/typescript-configs
- Add single CI for build, test, and linting
- Add Turborepo and common npm scripts
- Move Babel config to root level for better monorepo support
changesets/changesets
1
open
Shopify/web-configs
1
closed
Reviewed 21 pull requests in 1 repository
Shopify/polaris
21 pull requests
- Make Polaris for VS Code and Figma private to prevent publishing
- Polaris for VS Code, bundle using rollup
- Format command docs
- Vsc build updates
- Add support for tooltips in Navigation section items
- fix: Update config paths in stylelint-polaris tests
-
Clean
tsbuildinfoand add common scripts topolaris-for-figma -
polaris-for-vscodequick followups - stylelint use monorepo package
- mv /src/ ../
- Clean up recommended extensions
- Clean up tsconfigs to use shared @shopify/typescript-configs
- Root level jest config
- Add icon metadata to @shopify/polaris-icons
- Add icon docs to NPM
- Add single CI for build, test, and linting
- Adding polaris-for-figma plugin into the monorepo
- Configure babelrcRoots and update sub-packages
- Add Turborepo and common npm scripts
- Move Babel config to root level for better monorepo support
- fix: Polaris tokens ESM interoperability
Created an issue in changesets/changesets that received 2 comments
Use an alternative indicator for selecting packages
Affected Packages pkg:@changesets/cli
Problem When introducing Changesets to our repo, contributors had some difficulty identifying which packages …
2
comments
Opened 13 other issues in 1 repository
Shopify/polaris
10
closed
3
open
- Create and document prerelease workflow
- Remove shipit configs
- Remove TS project references
- Use GitHub Actions to release packages
- Use Changesets to handle versioning and releasing
- Update documentation for Turborepo workflow
-
Use directories to contain
packagesandapps - Clean up CI tasks
- Consolidate shared TypeScript configurations based on package type (base, nextjs, node14, react-library, etc)
- Create build, dev, lint, clean, and test scripts for root and sub package
- Use Turborepo or other tooling for smart scripts running across packages
- Use pnpm for optimized dependency management and monorepo support
- Use a single bundler for all packages that require a build step
14
contributions
in private repositories
May 6 – May 19