Skip to content
#

lightning-network

Here are 484 public repositories matching this topic...

C-Otto
C-Otto commented Dec 7, 2021

Background

Inspired by C-Otto/rebalance-lnd#241.

As part of pathfinding, lnd might encounter edges that have a policy specifying a zero CLTV delta (possibly because of no/outdated gossip?). Every time an edge like this is used in the pathfinding code, a warning is logged: https://github.com/lightningnetwork/lnd/blob/290b78e700021e238f7e6bdce6acc80de8d0a64f/routi

beginner good first issue logging P3
t-bast
t-bast commented Jul 2, 2021

When we return a bitcoin amount, our JSON responses currently specify the unit (btc, sat, msat) in the parameter name, but it's a bit ugly and is missing in some places.

Maybe it would be better to include the unit explicitly in the response. I see two different options:

  • Instead of returning a numeric value, return a string including the unit (e.g. "2500 msat", "0.45 btc", "1.5 mbtc"). The
RTL
saubyk
saubyk commented Nov 20, 2021

The rpcuser value is sensitive information and should not be displayed in the UI (/rtl/config/lnconfig).
We can take the following approaches to display the hidden information:
Password protect the config page and ask the user to enter password to display the page.

The expected behavior would be:

  • User clicks on the LND Config tab
  • The application prompts the user for entering the pas
enhancement good first issue vulnerability LND
Gesundeslicht
Gesundeslicht commented Aug 21, 2019
  • I'm submitting a ...

    • bug report
    • feature request
    • [x ] support request
  • What is the current behavior?

Traceback (most recent call last):
File "run.py", line 22, in
sys.exit(app.start())
File "/home/Martin/node-launcher/node_launcher/gui/application.py", line 32, in start
self.node_set.start()
File "/home/Martin/node-launcher/node_

bug good first issue
joule-extension
Technifocal
Technifocal commented May 29, 2019

Description of the Feature or Idea

Ratelimit the speed at which sites can create getInfo()/sendInvoice()/makeInvoice() requests if they require opening a window (for example, getInfo(), if pre-approved, should not be ratelimited). In testing, a buggy/malicious site can easily open tens or hundreds of windows.

Existing Example(s) of Feature

Here is an example piece of code to tri

bug good first issue
spark-wallet
shesek
shesek commented Sep 11, 2018

Some candidates for removal that could easily be re-implemented inside Spark:

  • superagent (only used for a simple HTTP GET request, can be replaced with the built-in http module)

  • helmet (sets security headers)

  • js-yaml (only used to format objects in a human-readable manner, we don't really need yaml)

  • nanoid (secure random string generator)

  • is-ip (few-liner depende

bitcoin-s
Christewart
Christewart commented Dec 13, 2021

Useful endpoints for the front end. It allows us to display to users if we are doing IBD or rescanning the wallet. This should add rescan and sync endpoints to indicate that the wallet is doing intiial block download (sync) or rescan which indicates the wallet is being rescanned.

{
  "wallet": {
    "keymanager": {
      "rootXpub": "zpub6jftahH18ngZyaghYHAYjB4MDxtYH4VZpLhkbeQot
enhancement good first issue wallet
nicolasburtey
nicolasburtey commented Apr 12, 2022

when an API user is creating an invoice, there is a way to pass a memo field. This memo is aimed to be included in the boltt11 invoice, and display to both the sender (because it's part of the invoice) and the recipient.

we should add another field called metadata that allow an API user to add more data related to a payment, without the API user to himself have to have an external database

Improve this page

Add a description, image, and links to the lightning-network topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the lightning-network topic, visit your repo's landing page and select "manage topics."

Learn more