Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire ServerListPingEvent for secondary motd send (fixes #8073) #8074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NoahvdAa
Copy link
Sponsor Contributor

@NoahvdAa NoahvdAa commented Jun 29, 2022

Fixes #8073. Not sure if there should be a flag on the event indicating whether it was fired for a connected player or just someone pinging.

@molor
Copy link

@molor molor commented Jun 29, 2022

there should be a flag on the event indicating whether it was fired for a connected player or just someone pinging

Maybe something like PaperServerListPingEvent#getReceiver() would be better in that case, e.g. if not null then it's fired for that connected player, otherwise it's some1 pinging

But there's already PaperServerListPingEvent#getBukkitPlayer() (mentioned in javadocs without any useful information) and idk maybe it's already can be used for that, I'm sorry in that case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants