Bitcoin

The -datacarrier and -datacarriersize options were added in #3715 and #5077. Seems like those PRs did not add tests and we still don't have tests for them...? It should be easier to test things like this now with functional tests. I see -datacarriersize used in some places to create large transactions by stuffing outputs with lots of data but that's not very thorough. We should probably add

Describe your environment

N/A

Describe the enhancement

Currently it seems the max_open_trades can have significant impact on profit. The only way I have been able to find a good number is to run several back

Problem

Loss and latency metrics might be interesting from the gossip ping-pong protocol.

Proposed Solution

Capture and report them.

Creating a new issue based on lbryio/lbry-sdk#877

• Update ensure_directory_exists() to check that the directory is writable by the current process.
• If it's not, return a useful error
• Add tests to cover the case when
  • download directory does not exist
  • download dir exists but is not writable
  • dir exists an

ioutil.WriteFile doesn't sync the data to disk, so any data written with this function can easily be lost. It's even possible that only partial writes happen. Issuing an Fsync is a better alternative. There aren't many call-sites that do this and I wasn't able to evaluate whether any of these were critical, but better to be safe than sorry.

Description

The "send payment" dialogue after seller taker accepted my offer is telling me to "start payment using sepa instant"; the account I used is normal sepa.

Version

1.8.0

S

Reading currencies, alphavantage returns a greeting note ("welcome") and this note raises an error in alphavantage.py line 363.

            elif "Note" in json_response and self.treat_info_as_error:
                raise ValueError(json_response["Note"])

For this reason, alphavantage does not work in home assistant.

Working on #3873 I noticed that we do not have an edit view for pull payments. Though the amount might be fixed after creation, we now have some more fields like title and description, which should be editable afterwards.