Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: add encoding parameter to benchmarks #44278

Merged
merged 1 commit into from Aug 21, 2022
Merged

fs: add encoding parameter to benchmarks #44278

merged 1 commit into from Aug 21, 2022

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented Aug 18, 2022 •
edited

Example output

fs/readfile.js concurrent=1 len=1024 encoding="undefined" duration=5: 40,590.2356841829
fs/readfile.js concurrent=10 len=1024 encoding="undefined" duration=5: 115,114.82816873376
fs/readfile.js concurrent=1 len=16777216 encoding="undefined" duration=5: 877.7391872447944
fs/readfile.js concurrent=10 len=16777216 encoding="undefined" duration=5: 942.8575813623352
fs/readfile.js concurrent=1 len=1024 encoding="utf-8" duration=5: 37,029.85724031153
fs/readfile.js concurrent=10 len=1024 encoding="utf-8" duration=5: 100,228.93646632427
fs/readfile.js concurrent=1 len=16777216 encoding="utf-8" duration=5: 278.740263620088
fs/readfile.js concurrent=10 len=16777216 encoding="utf-8" duration=5: 355.10858887408915

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system. labels Aug 18, 2022
@anonrig anonrig mentioned this pull request Aug 18, 2022
Closed
mscdex
mscdex reviewed Aug 18, 2022
View changes
benchmark/fs/readfile-partitioned.js Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Aug 19, 2022
View changes
Copy link
Member

@mcollina mcollina left a comment

lgtm

mscdex
mscdex reviewed Aug 19, 2022
View changes
benchmark/fs/readfile-promises.js Outdated Show resolved Hide resolved
mscdex
mscdex reviewed Aug 19, 2022
View changes
benchmark/fs/readfile.js Outdated Show resolved Hide resolved
RafaelGSS
RafaelGSS approved these changes Aug 20, 2022
View changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

LGTM.

@anonrig
Copy link
Contributor Author

anonrig commented Aug 20, 2022

Can we get this pull request merged?

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit f187fb4 into nodejs:main Aug 21, 2022
19 checks passed
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Aug 21, 2022

Landed in f187fb4

ruyadorno pushed a commit that referenced this issue Aug 23, 2022
@anonrig @ruyadorno
fs: add encoding parameter to benchmarks
4ec3f67 
PR-URL: #44278
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@ruyadorno ruyadorno mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex

@mcollina mcollina

@RafaelGSS RafaelGSS

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anonrig @nodejs-github-bot @mcollina @mscdex @RafaelGSS