New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Impeller] Linear to sRGB Gamma filter implementation. #35388
Conversation
|
This needs to be rebased as |
|
Just realized this is a separate PR to #35441. I don't think these need to be landed as totally distinct filters given the only difference between the two should be the fragment shader (and the fragment shader should require the exact same uniform/varying layout). I recommend renaming this filter to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Since these work, we should definitely land them. These conversions can be combined later in follow-ups.
The changes proposed in this PR implement the Linear Gamma to sRGB filter in Impeller alongside accompanying tests.
Below is a screenshot of the playground. The image on the left is the unfiltered image and the one on the right is the filtered one.
Solves flutter/flutter#109738.
writing and running engine tests.
///).