Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: standardize the HTML, CSS and JSP in the webapps folder. #316

Open
wants to merge 1 commit into
base: master
from

Conversation

@jbampton
Copy link
Contributor

@jbampton jbampton commented Jul 4, 2020

Use lowercase HTML tags and attributes.
Add quotes around attributes.
Standardize quotes.
Fix some HTML errors.
Use HTML5 and CSS.
Remove whitespace and blank lines.
Indent HTML and JSP.

@kkolinko
Copy link

@kkolinko kkolinko commented Jul 5, 2020

error.html:

  1. Shouldn't it better be <form method="GET"?
  2. Options shall be closed with . The
    s there are out of place and ignored. (validator.w3.org complains)
@jbampton jbampton force-pushed the jbampton:fix-html branch from c4dfa36 to 2406b0a Jul 6, 2020
@jbampton
Copy link
Contributor Author

@jbampton jbampton commented Jul 6, 2020

Hey @kkolinko I removed the br tags and also closed the option tags now.

I also validated the 'error.html' by direct upload and it validates now.

https://validator.w3.org/#validate_by_input

@jbampton jbampton force-pushed the jbampton:fix-html branch 7 times, most recently from 0b8fdf7 to e844277 Jul 6, 2020
@@ -25,11 +25,11 @@ request.setAttribute("tomcatExamplesUrl", "/examples/");
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta charset="UTF-8">

This comment has been minimized.

@martin-g

martin-g Jul 6, 2020
Member

Why did you remove the auto-closing ? It doesn't do any harm. I, personally, prefer the style it was before.

This comment has been minimized.

@jbampton

jbampton Jul 6, 2020
Author Contributor

In HTML5 you don't need the auto-closing.
I got the style from MDN.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta

This comment has been minimized.

@martin-g

martin-g Jul 6, 2020
Member

I know, but it does not do any harm either.
This change makes the diff bigger and harder to back-port to the other branches.
I prefer the XHTML style because it is easier to spot errors in the IDE/text editor without copying to W3C validator in the web.

webapps/examples/jsp/cal/cal1.jsp Outdated Show resolved Hide resolved
webapps/examples/jsp/cal/cal1.jsp Outdated Show resolved Hide resolved
webapps/examples/jsp/cal/cal2.jsp Outdated Show resolved Hide resolved
@jbampton jbampton requested a review from michael-o Jul 6, 2020
@jbampton jbampton force-pushed the jbampton:fix-html branch from e844277 to 6bcb3e2 Jul 6, 2020
webapps/ROOT/index.jsp Outdated Show resolved Hide resolved
@jbampton jbampton force-pushed the jbampton:fix-html branch from 6bcb3e2 to 953416e Jul 31, 2020
@jbampton
Copy link
Contributor Author

@jbampton jbampton commented Jul 31, 2020

error.html:

  1. Shouldn't it better be <form method="GET"?
  2. Options shall be closed with . The s there are out of place and ignored. (validator.w3.org complains)

MDN says -> Possible (case insensitive) values
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/form

Screen Shot 2020-08-01 at 5 31 33 am

@jbampton jbampton force-pushed the jbampton:fix-html branch 8 times, most recently from bb5d215 to 735e437 Jul 31, 2020
@jbampton jbampton changed the title Use lowercase HTML tags and attributes. Add quotes around attributes. Standardize the HTML, CSS and JSP in the webapps folder. Aug 1, 2020
@jbampton jbampton force-pushed the jbampton:fix-html branch 2 times, most recently from 8c818fe to 1e7d050 Aug 1, 2020
Use lowercase HTML tags and attributes.
Add quotes around attributes.
Fix some HTML errors.
Use HTML5 and CSS.
Indent HTML and JSP.
Remove whitespace.
Remove blank lines.
Standardize quotes.
@jbampton jbampton force-pushed the jbampton:fix-html branch from 1e7d050 to 192c368 Sep 16, 2020
@jbampton jbampton changed the title Standardize the HTML, CSS and JSP in the webapps folder. refactor: standardize the HTML, CSS and JSP in the webapps folder. Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants