Skip to content
Permalink
main
Switch branches/tags

Commits on Sep 13, 2022

  1. Bump versions [skip ci]

    rushbot committed Sep 13, 2022
  2. Update changelogs [skip ci]

    rushbot committed Sep 13, 2022
  3. Merge pull request #3623 from dmichon-msft/fix-parallelism-percentage

    [rush-lib] Fix parallelism percentage parsing
    octogonz committed Sep 13, 2022

Commits on Sep 12, 2022

  1. Merge pull request #3602 from fwienber/fwienber/api-extractor-fix-359…

    …3-reference-alias
    
    [api-extractor] Fix #3593 Incorrect canonical reference to aliased class in .api.json
    octogonz committed Sep 12, 2022
  2. Merge pull request #3622 from microsoft/octogonz/gitignore-intellij

    Update the .gitignore template to ignore files generated by IntelliJ IDEA
    iclanton committed Sep 12, 2022
  3. Update change file

    octogonz committed Sep 12, 2022
  4. Convert "firstExportingConsumableParent" property to "getFirstExporti…

    …ngConsumableParent()" method because it does nontrivial work
    octogonz committed Sep 12, 2022
  5. rush change

    octogonz committed Sep 12, 2022
  6. Merge pull request #3621 from iclanton/user/ianc/duplicate-resx-strin…

    …g-test
    
    [localization utilities] Add a test for a RESX file with a duplicate entry.
    iclanton committed Sep 12, 2022
  7. Bump versions [skip ci]

    rushbot committed Sep 12, 2022
  8. Update changelogs [skip ci]

    rushbot committed Sep 12, 2022
  9. rush build

    octogonz committed Sep 12, 2022
  10. Merge remote-tracking branch 'remotes/origin/main' into fwienber/api-…

    …extractor-fix-3593-reference-alias
    
    # Conflicts:
    #	apps/api-extractor/src/collector/CollectorEntity.ts
    #	build-tests/api-extractor-scenarios/etc/exportImportStarAs2/api-extractor-scenarios.api.json
    #	build-tests/api-extractor-scenarios/etc/namespaceImports/api-extractor-scenarios.api.json
    #	build-tests/api-extractor-scenarios/etc/namespaceImports2/api-extractor-scenarios.api.json
    octogonz committed Sep 12, 2022
  11. Merge pull request #3619 from zelliott/namespace-import-fix

    [api-extractor] Fix a bug where an item is exported from both the entry point and an exported `AstNamespaceImport`.
    octogonz committed Sep 12, 2022
  12. Clarify change log

    octogonz committed Sep 12, 2022
  13. Merge pull request #3618 from dmichon-msft/before-install-hook

    [rush-lib] Add "beforeInstall" hook
    iclanton committed Sep 12, 2022

Commits on Sep 9, 2022

Commits on Sep 8, 2022

  1. [api-extractor] Fix logic when to fall back to Navigation.Exports

    As suggested by @zelliott, the logic when to fall back
    to Navigation.Exports (`.`) must use `consumable`, not
    `exported`.
    Updated the improved build-tests/api-extractor-scenarios
    results.
    fwienber committed Sep 8, 2022
  2. Ran rush change

    zelliott committed Sep 8, 2022
  3. Tidying up PR

    zelliott committed Sep 8, 2022
  4. Merge pull request #2 from zelliott/pr-3602-review

    Some proposed changes to #3602
    fwienber committed Sep 8, 2022
  5. Added a comment

    zelliott committed Sep 8, 2022
  6. Changes to #3602

    zelliott committed Sep 8, 2022

Commits on Sep 7, 2022

  1. Nit fix

    zelliott committed Sep 7, 2022
  2. WIP AstNamespaceImport fix

    zelliott committed Sep 7, 2022

Commits on Sep 6, 2022

  1. Merge pull request #3608 from dmichon-msft/verify-store-integrity

    [rush-lib] Add RUSH_PNPM_VERIFY_STORE_INTEGRITY environment variable
    iclanton committed Sep 6, 2022

Commits on Sep 2, 2022

  1. [api-extractor] Fix 'export * as __' part of #3593

    "Incorrect canonical reference to aliased class in .api.json"
    #3593
    
    This fixes the other aliasing, namely through (nested)
    namespaces.
    Added a test scenario "docReferencesNamespaceAlias", which
    consists of nested namespaces that have their own index.d.ts,
    re-exporting the default export of each sibling file and
    their respective sub-namespace (top-level -> 'renamed'
    -> 'sub').
    The *.api.json canonicalReferences now correctly use the
    nested namespace "fully-qualified name".
    
    Again, some other test result changed unexpectedly, maybe
    revealing an existing bug / wrong expected result.
    The scenarios are "exportImportStarAs2", "importEquals"
    and "includeForgottenExports". The pattern is that
    before, namespace and class were separate tokens, but
    are now aggregated to one dot-separated expression.
    I hope that these are improvements, but I am not sure,
    so this should be reviewed.
    
    Implementation:
    ---------------
    When DeclarationReferenceGenerator#_getParentReference()
    looks for a parent symbol, it must also resolve
    namespace parent symbols the Collector derived from
    'import * as ___'.
    To that end, Collector now has a method
    getExportingNamespace() that pulls namespace imports from
    the CollectorEntities of a namespace symbol (if present).
    For that, namespace imports are now also registered in the
    _entitiesBySymbol Map.
    In DeclarationReferenceGenerator, the handling of
    namespaces had to be improved. _getNavigationToSymbol()
    now detects namespaces, even behind an alias, and
    then always returns "." as separator. To find the
    parent, it also considers namespaces now.
    _symbolToDeclarationReference() takes care not to
    follow an alias that leads to a *-imported namespace,
    because the target is the imported source file that
    no longer allows to retrieve the namespace name.
    fwienber committed Sep 2, 2022
  2. [api-extractor] Fix 'export __ as __' part of #3593

    "Incorrect canonical reference to aliased class in .api.json"
    #3593
    
    Fix first scenario from #3593.
    
    Added test scenario "docReferencesAlias", inspired by
    the test repo referenced in the GitHub issue:
    
    `Item` and `Options` are default exports of two
    separate source files, and `index` re-exports both,
    renaming `Options` to `renamed_Options` (preserving
    the "namespacing" information of the directory).
    
    `DeclarationReferenceGenerator` now receives a function
    to resolve a Symbol to its emit name.
    `ApiModelGenerator` fetches this function from `Collector`,
    which now maintains another map from symbol to
    `CollectorEntity`. If for a given symbol, there is
    a `CollectorEntity`, then its `emitName` is returned,
    the symbol's name otherwise.
    
    While this change fixes the `export { __ as __ }`
    scenario, for _some_ reason, it changes the output
    of one other test scenario, namely "ambientNameConflict".
    In its `*.api.json` file, some reference to the
    class re-exported as `MyPromise`, the name clash
    of localFile's `Promise` and the global `Promise`
    now leads to `Promise_2` being used instead of
    `Promise`, the old expected result that was also
    wrong, because it should have been `MyPromise`,
    and `MyPromise` should appear in `*.api.json`, but
    that is something completely different, so I'll
    ignore the problem for now and check in the changed
    expected `*.api.json` of "ambientNameConflict".
    fwienber committed Sep 2, 2022
Older