odeke-em
Follow
Popular repositories
1,456 contributions in the last year
Less
More
Activity overview
Contribution activity
September 2022
Created 25 commits in 8 repositories
Created a pull request in cosmos/cosmos-sdk that received 9 comments
fix: types: correctly coalesce coins even with repeated denominations & simplify logic
This code correctly coalesces coins with repeated denominations which can come from mistakenly duplicated or split up coins being passed in. Howeve…
+54
−51
•
9
comments
Opened 27 other pull requests in 9 repositories
cosmos/gosec
8
merged
1
open
- rules/sdk: exclude "testutil" from map ranging checks
- rules/errors: allow hash.Hash.Write to not return an error as its Go contract holds
- .github/workflows/ci: test on Go1.17,1.18,1.19
- all: fix tests by migrating to github.com/onsi/ginkgo/v2
- rules/sdk: sdk allow unsafe+*/rand in specific packages
- analyzer: move generated file filtering to ast.Walk phase not in package building
- analyzer: do not analyze generated go files
- go.mod: fix go vet go.sum complaints
- all: migrate from github.com/informalsystems/* to github.com/cosmos/*
cosmos/cosmos-sdk
1
open
6
merged
1
closed
- ci: .github/workflows: add staticmajor to catch leaking resources
- fix: all: remove map iteration non-determinism with keys + sorting
- fix: x/gov/client/cli: update & tighten Prompt.Parse tests
- chore: all: use golang.org/x/exp/maps.(Keys, Values) where necessary
- fix: x/gov/client/cli: fix integer overflow in parsing int prompted values
- fix: crypto/keys/secp246k1/*: add +build cgo guard to avoid failure with CGO_ENABLED=0
- ci: .github/workflows: add staticmajor to catch leaking resources
- perf: all: remove unnecessary allocations from strings.Builder.WriteString(fmt.Sprintf(...))
tendermint/tendermint
1
merged
1
open
ingenuity-build/quicksilver
2
merged
cosmos/iavl
2
merged
cosmos/relayer
1
open
tailscale/tailscale
1
merged
Reviewed 15 pull requests in 6 repositories
cosmos/cosmos-sdk
6 pull requests
cosmos/gosec
4 pull requests
tendermint/tendermint
2 pull requests
tailscale/tailscale
1 pull request
census-instrumentation/opencensus-website
1 pull request
ingenuity-build/quicksilver
1 pull request
Created an issue in golang/go that received 11 comments
all: resource leaks due to missing .Close() calls in various conditions
What version of Go are you using (go version)?
$ go version go version devel go1.20-a813be86df Tue Sep 13 17:43:40 2022 +0000 darwin/amd64
Does t…
11
comments
Opened 20 other issues in 6 repositories
cosmos/cosmos-sdk
5
closed
1
open
- store/internal/proofs: SortedKeys could simply use golang.org/x/exp/maps.Keys and sort.Strings
- x/gov/client/cli: integer overflow from ignoring output of strconv.Atoi
- crypto/keys/secp256k1/internal/secp256k1: secp256_test.go fails when CGO_ENABLED=0 yet other files are guarded and run only with cgo enabled
- types: Coins.Add chokes if a denomination is repeated and does not coalesce coins with same denomination {{2A}, {3A}, {1A}}.Add({2A}. {3A}) gives back {{5A}, {5A}, {1A}} but it should return {{10A}}
- all: avoid (strings.Builder).WriteString(fmt.Sprintf(...)) and instead use fmt.Fprintf((*strings.Builder), ...) for better performance
- Makefile: mitigate supply chain risk of curl downloading rogue protobuf dependencies without verifying nor signing
cosmos/gosec
3
closed
2
open
- rules/sdk: skip map iteration checks for testutil code
- errors: do not report a unhandled error on hash.Hash.Write code which by contract WILL NEVER return an error
- rules/sdk: ignore unsafe imports inside any simapp or simulation, cryptographic, testing related code
- rules/sdk: flag methods inside sort comparators to avoid quadratic worst case time & memory consumption: instead recommend O(n) computations and memoization of results
- rules/sdk: flag panics in BeginBlock/Endblock
cosmos/ibc-go
5
open
- modules/core/02-client/types: IsClientIDFormat regex permits invalid client types due to misinterpretation of regex syntax for character sets and also doesn't respect the specification which requires entirely ASCII
- modules/core/keeper: NewKeeper blank value detection assumes interface values are all non-pointer receivers and will fail to detect blank pointer receivers
- modules/apps/27-interchain-accounts/controller/keeper: Keeper.SendTx doesn't seem to respect the zero value for types.MsgSendTx.TimeoutTimestamp which signifies being disabled
- modules/apps/27-interchain-accounts/controller/types: (Params).Validate suspiciously performs no checks yet unnecessary conversions from bool to interface then checks if value is a bool and not if it is enabled
- modules/apps/27-interchain-accounts/types: simply use a string concatenation instead of fmt.Sprint(PortPrefix, owner) to build PortID in NewControllerPortID
cosmos/iavl
2
closed
tailscale/tailscale
1
closed
83
contributions
in private repositories
Sep 1 – Sep 26