ryan953
Follow
Pinned
558 contributions in the last year
Activity overview
Contribution activity
July 2022
Created 3 commits in 3 repositories
Created 2 repositories
- ryan953/sharedworker TypeScript
- ryan953/rrweb TypeScript
Created a pull request in getsentry/sentry that received 13 comments
feat(replays): Fix issues in Replay Details v2 layout and replace the original layout styles
This is a big iteration on the v2 layout for Replay Details, so big that I've just gone and removed/replaced the v1 code so we've only got the one …
+915
−895
•
13
comments
Opened 13 other pull requests in 3 repositories
getsentry/sentry
2
open
9
merged
- ref(replays): Remove unneeded TimelinePosition and fold its css into scrubber.tsx
- ref(replays): Remove unused highlightReplayPlugin
- feat(replays): Create the new DOM tab for Replays
- fix(replays): Fix border radius on the last Console row
- feat(replays): Update controller button style to match designs
- feat(replays): Make the replay video resize in all directions to match its container size
- ref(tags): Refactor the Tags table so the rows are independant of the styled title
- ref(replays): Refactor MouseTracking component into a react hook
- bug(replays): Remove the custom replays navTabs, use core nav which supports with dark-mode
- feat(replays): Cleanup unneeded tabs from the Replay Details page
- feat(replays): Rewrite navtabs so click targets are bigger
okikio/sharedworker
1
merged
rrweb-io/rrweb
1
open
Reviewed 17 pull requests in 1 repository
getsentry/sentry
17 pull requests
- feat(replays): Create the new DOM tab for Replays
- feat(replays): Event Details Replay Section Player
- fix(replays): add padding for breadcrumbs
- feat(replays): Condensed Replay Timeline View
- feat(replays): Replay event data section
- feat(replays): Fix issues in Replay Details v2 layout and replace the original layout styles
- feat(replays): Update controller button style to match designs
- feat(replays): Make the replay video resize in all directions to match its container size
- feat(replays): New Replay Player Options Dropdown
- feat(replays): Improved Replay Details Header
- ref(tags): Refactor the Tags table so the rows are independant of the styled title
- feat(replays): Improved Breadcrumb Signifiers and Functionality
- feat(replays): Updated player control tooltips and icons
- feat(replays): Sidebar Left Layout
- feat(replays): adds compact mode for player control bar
- feat(replays): aside tabs for sidebar layout
- feat(replays): Rewrite navtabs so click targets are bigger
Created an issue in getsentry/sentry that received 1 comment
Design Nit: Fix Timeline colors -> should be purple300 for current and hoverTime
The “hover bar” background colour to be purple100 which is transparent colour, meaning if the cursor hovers over the “elapsed time bar” as shown in…
1
comment
Opened 25 other issues in 1 repository
getsentry/sentry
22
open
3
closed
-
Design Nit: The whole Details page scrolls when there's a page-wide
.messages-containerbanner - Bug: If a replay doesn't have any dom changes, only focus/blur type of thing, then Fast-forward doesn't work
- Implement basic DOM inspector
- Show a banner if the Deveopers browser is different from the browser that was used when the capture was taken
- Design Nit: Timeline current & hover state doesn't have rounded corners, purple rectangles stick out past the border
- Bug: SplitPanel should disable mouse event handlers when the pointer is not pressed
- Design Nit: Timeline should not have extra 'rectangle' sticking out above the hoverTime marker -> remove it
- Design Nit: Timeline events should be clickable and open the relevant detailed tab
-
Design Nit:
VideoSectionhas a black background in fullscreen mode - Bug: Replay sidebar can be resized to cutoff the video box
-
Design Nit: Header KeyMetrics never shows
<Placeholder>elements - Design Nit: Header isn't as wide as the body
- Bug: Options dropdown failing to activate on first click in full screen
- Bug: Replay details view dark mode tabs not looking right
- Create/Find a component to render a string of html in a nicely formatted/colored way
- Performance > Event page should include a replay preview (the player) in the page as we do for the current rrweb integration
- List Replay grouped by urls visited
- Network Table should have decent basic styles
- Refactor useReplayData and ReplayReader to read data from the replay-specific API endpoints
- Refactor index page to read data from the new API endpoints
- Tracing tab should have an Upsell (sass) or a how-to-config Message (on-prem) when tracing is disabled
- Player should enable "Fast-forward" through inactive times by default
- Replay Details should have a layout version called something like 'sidebar-left'
- Performance > Summary pages should include a new Tab called "Replays" to list all the replays that include this transaction
- List page should allow filtering by "# of errors" column
20
contributions
in private repositories
Jul 5 – Jul 21