THRIFT-5635: update erlang client #2677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much appreciated! |
|
Is this still draft? |
|
Hi @Jens-G, in general I've made almost all planned changes, some missed tweaks for multiplexer can be added via another PR, I think. So in my opinion this PR is ready for review. |
kpy3
changed the title
Summary of changes: - Add useful compiler options - Format sources using erlfmt - Switch to modern callbacks in thrift_* modules - Add static analysis (dialyzer), disabled by default - Add/fix types for API calls NOTE: Enabling static analysis requires additional tweaks in multiplexer module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to update Erlang client with modern features and tools
Added useful compiler, ref and dialyzer flags
Added types to record fields in states
Added missing specs for function
Reformat source code using erlfmt (de-facto standard in Erlang world)
Replace deprecated and removed syntax constructs and functions with counterparts
https://issues.apache.org/jira/browse/THRIFT-5635
If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
Did you squash your changes to a single commit? (not required, but preferred)
Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
If your change does not involve any code, include
[skip ci]anywhere in the commit message to free up build resources.