Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always use ? for anonymous function name #5664

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Aug 31, 2022

Closes #5523

This moves the '?' string to @sentry/utils so it only exists once in the bundle.

@timfish timfish force-pushed the fix/normalize-anon-fn-to-question-mark branch from 278b227 to 6c22fa5 Compare Aug 31, 2022
Lms24
Lms24 approved these changes Sep 1, 2022
Copy link
Member

@Lms24 Lms24 left a comment

LGTM

@timfish timfish marked this pull request as draft Sep 1, 2022
@timfish
Copy link
Collaborator Author

timfish commented Sep 1, 2022

Abhi has marked this for v8.0.0 since this is technically a breaking change

@AbhiPrasad AbhiPrasad added this to the 8.0.0 milestone Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 23, 2022

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack parsers use both ? and <anonymous> to denote anonymous functions
3 participants