Refactor sequences #2669
Merged
Refactor sequences #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erg
force-pushed
the
refactor-sequences
branch
from
84d6b79
to
5aa6824
Compare
erg
force-pushed
the
refactor-sequences
branch
from
5aa6824
to
0358c40
Compare
erg
force-pushed
the
refactor-sequences
branch
from
8b44a67
to
0c1b8b7
Compare
|
Not a huge fan of all the The other cleanups look great! |
erg
force-pushed
the
refactor-sequences
branch
from
1e3f1a3
to
2119933
Compare
erg
force-pushed
the
refactor-sequences
branch
from
2119933
to
43c1078
Compare
erg
force-pushed
the
refactor-sequences
branch
from
43c1078
to
40ef64d
Compare
erg
force-pushed
the
refactor-sequences
branch
from
40ef64d
to
0344b70
Compare
erg
force-pushed
the
refactor-sequences
branch
4 times, most recently
from
cccd2ad
to
eb931db
Compare
third one breaks if you mess up rewriting sequence-copy-unsafe too bad XD
found by `"sequences" lint-vocab`
put back the `[ ] like` fixes #2763
erg
force-pushed
the
refactor-sequences
branch
from
eb931db
to
de11ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I tried to make sequences words better by factoring and renaming and rearranging the stack effects. This branch is starting to diverge from master so I'd rather try to get this code into master and fix any inconsistencies or critiques.