Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): update contribution guide #17754

Merged
merged 8 commits into from Oct 4, 2022

Conversation

PeterNgTr
Copy link
Contributor

@PeterNgTr PeterNgTr commented Oct 1, 2022

I'm following this guide to run local tests however, I'm struggling to make it up and running.
https://github.com/microsoft/playwright/blob/main/CONTRIBUTING.md

This PR aims to update docs to help anyone who gets into trouble like me.

@PeterNgTr
Copy link
Contributor Author

PeterNgTr commented Oct 1, 2022

@microsoft-github-policy-service agree

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
PeterNgTr and others added 4 commits Oct 1, 2022
Co-authored-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
@PeterNgTr
Copy link
Contributor Author

PeterNgTr commented Oct 1, 2022

thanks @mxschmitt!

CONTRIBUTING.md Outdated Show resolved Hide resolved
@mxschmitt mxschmitt merged commit 253e3d2 into microsoft:main Oct 4, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants