Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Eliminate uses of EarlyDocLinkResolver::all_traits #103192

Merged
merged 1 commit into from Oct 23, 2022
Merged

rustdoc: Eliminate uses of EarlyDocLinkResolver::all_traits #103192

merged 1 commit into from Oct 23, 2022

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Oct 18, 2022

Another step to #94857.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 18, 2022
@rust-highfive
Copy link
Collaborator

rust-highfive commented Oct 18, 2022

r? @notriddle

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2022
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Oct 18, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Oct 18, 2022

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 18, 2022
@bors
Copy link
Contributor

bors commented Oct 18, 2022

⌛ Trying commit c705f4b with merge 1193205...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 18, 2022
@bors
Auto merge of rust-lang#103192 - petrochenkov:noalltraits, r=<try>
1193205 
rustdoc: Eliminate uses of `all_traits`

Another step to rust-lang#94857.
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2022
@bors
Copy link
Contributor

bors commented Oct 18, 2022

☀️ Try build successful - checks-actions
Build commit: 1193205 (1193205dc5163a9e46ee425d84782538e5d21fc7)

@rust-timer
Copy link
Collaborator

rust-timer commented Oct 18, 2022

Queued 1193205 with parent 21b2465, future comparison URL.

@rust-timer
Copy link
Collaborator

rust-timer commented Oct 18, 2022

Finished benchmarking commit (1193205): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 19.1% [0.7%, 50.8%] 17
Regressions ❌
(secondary)		 18.5% [0.6%, 59.0%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 19.1% [0.7%, 50.8%] 17

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.2% [2.2%, 4.0%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 18.8% [2.8%, 44.2%] 16
Regressions ❌
(secondary)		 17.9% [2.7%, 50.8%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 18.8% [2.8%, 44.2%] 16

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot added perf-regression Performance regressions S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 18, 2022
jyn514
jyn514 reviewed Oct 19, 2022
View changes
src/librustdoc/clean/blanket_impl.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2022
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Oct 19, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Oct 19, 2022

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 19, 2022
@petrochenkov petrochenkov changed the title rustdoc: Eliminate uses of all_traits rustdoc: Eliminate uses of EarlyDocLinkResolver::all_traits Oct 19, 2022
@petrochenkov petrochenkov removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. perf-regression Performance regressions labels Oct 19, 2022
@bors
Copy link
Contributor

bors commented Oct 19, 2022

⌛ Trying commit 1754745 with merge 6d36958...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2022
@bors
Auto merge of rust-lang#103192 - petrochenkov:noalltraits, r=<try>
6d36958 
rustdoc: Eliminate uses of `EarlyDocLinkResolver::all_traits`

Another step to rust-lang#94857.
@bors
Copy link
Contributor

bors commented Oct 19, 2022

☀️ Try build successful - checks-actions
Build commit: 6d36958 (6d369582bc7ad1b14d8af114b37b1ece37e8be86)

@rust-timer
Copy link
Collaborator

rust-timer commented Oct 19, 2022

Queued 6d36958 with parent 84365ff, future comparison URL.

@rust-timer
Copy link
Collaborator

rust-timer commented Oct 19, 2022

Finished benchmarking commit (6d36958): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 19, 2022
@petrochenkov
Copy link
Contributor Author

petrochenkov commented Oct 19, 2022

@bors rollup=maybe
@rustbot ready

@jyn514
Copy link
Member

jyn514 commented Oct 19, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Oct 19, 2022

📌 Commit 1754745 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2022
@bors
Auto merge of rust-lang#103431 - Dylan-DPC:rollup-oozfo89, r=Dylan-DPC
9be2f35 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#101293 (Recover when unclosed char literal is parsed as a lifetime in some positions)
 - rust-lang#101908 (Suggest let for assignment, and some code refactor)
 - rust-lang#103192 (rustdoc: Eliminate uses of `EarlyDocLinkResolver::all_traits`)
 - rust-lang#103226 (Check `needs_infer` before `needs_drop` during HIR generator analysis)
 - rust-lang#103249 (resolve: Revert "Set effective visibilities for imports more precisely")
 - rust-lang#103305 (Move some tests to more reasonable places)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e426874 into rust-lang:master Oct 23, 2022
11 checks passed
@rustbot rustbot added this to the 1.66.0 milestone Oct 23, 2022
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2022
@rust-timer
Unrolled build for rust-lang#103192
15ad069
@SarthakSingh31 SarthakSingh31 mentioned this pull request Oct 25, 2022
Closed
@petrochenkov petrochenkov mentioned this pull request Nov 13, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#104364 - petrochenkov:docice2, r=GuillaumeG…
7bb7bf7 
…omez

rustdoc: Resolve doc links in external traits having local impls

For external impls it was done in rust-lang#103192 right away, but the local impl case was forgotten.

Fixes rust-lang#104145.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#104364 - petrochenkov:docice2, r=GuillaumeG…
0a48a45 
…omez

rustdoc: Resolve doc links in external traits having local impls

For external impls it was done in rust-lang#103192 right away, but the local impl case was forgotten.

Fixes rust-lang#104145.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#104364 - petrochenkov:docice2, r=GuillaumeG…
dc869fc 
…omez

rustdoc: Resolve doc links in external traits having local impls

For external impls it was done in rust-lang#103192 right away, but the local impl case was forgotten.

Fixes rust-lang#104145.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514

Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@petrochenkov @rust-highfive @rust-timer @bors @jyn514 @notriddle @rustbot