Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Don't generate broken source link for topic pages #2843

Merged
merged 1 commit into from Oct 23, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 22, 2022

To reproduce:

  1. Go to a topic index page:
  2. Click "Page Source (GitHub)" in the left menu

Actual result:

404 this is not the page you are looking for, because these pages are generated at build time and don't exist in the Git repo.

Expected result:

Either no 404, or no link in the first place.

Fix:

Let's not generate the link.

Preview:

@hugovk hugovk added bug infra Core infrastructure for building and rendering PEPs labels Oct 22, 2022
@hugovk hugovk requested a review from AA-Turner as a code owner Oct 22, 2022
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Oct 22, 2022

There's also @pradyunsg 's proposal to shift the logic to a directive rather than the somewhat hacky source file generation we're using right now, which would also avoid this :)

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Oct 23, 2022

We can switch to the directive logic when the code for that exists, but in the meantime let's fix this bug. Thanks @hugovk!

@JelleZijlstra JelleZijlstra merged commit 1a931bf into python:main Oct 23, 2022
15 checks passed
@hugovk hugovk deleted the fix-topic-page-source branch Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug infra Core infrastructure for building and rendering PEPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants