odeke-em
Follow
Popular repositories
1,401 contributions in the last year
Less
More
Activity overview
Contribution activity
October 2022
Created 21 commits in 5 repositories
Created a pull request in cosmos/cosmos-sdk that received 2 comments
fix: cosmovisor: isolate and return masked errors that are not non-existence errors
Enumerates and improves on the error checking for non-existance errors to clearly return unhandled errors such as access restrictions, unaccessible…
+8
−1
•
2
comments
Opened 18 other pull requests in 6 repositories
cosmos/gosec
6
merged
1
closed
- rules/sdk: allow hash.Hash.Write et al to ignore errors since contract permits
- analyzer: parallelize (*Analyzer).Process for better CPU use
- rules/sdk: allow packages with */crypto/* to import unsafe
- analyzer: skip over files under /tests
- rules/sdk: intelligently flag overflowing uint*->uint* + int*->int* conversions
- rules/sdk: more accurately determine overflow for *int*(len(...)) by type & 32/64-bit architectures
- (*Analyzer).Check: skip analyzing files within */testutil/*
cosmos/chainparse
1
open
3
merged
- chainparse: always use latest go.mod since chain-registry not maintained
- chainparse: parallelize fetching & fetch default branch from git directly
- all: also retrieve latest Github go.mod since registry isn't always accurate
- chainparse: defer to checking go.mod replace directives for authoritative final versions+URLs
celestiaorg/nmt
1
open
2
merged
cosmos/cosmos-sdk
1
merged
1
open
tendermint/tendermint
1
closed
Reviewed 12 pull requests in 6 repositories
cosmos/cosmos-sdk
3 pull requests
coredns/coredns
3 pull requests
tailscale/tailscale
2 pull requests
klauspost/reedsolomon
2 pull requests
celestiaorg/nmt
1 pull request
cosmos/ibc-go
1 pull request
Created an issue in coredns/coredns that received 3 comments
plugin/reload: leaking (*time.Ticker) in goroutine inside hook
Reported by Static Major from Orijtech Inc, we can see this /coredns/plugin/reload/reload.go:118:6: leaking resource created on line 85 /coredns/pl…
3
comments
Opened 21 other issues in 7 repositories
cosmos/gosec
6
closed
1
open
- rules/sdk: G702: Blocklisted import crypto/rand should not flag for crypto related code
- rules/sdk: G703 errors not propagated should obey hash.Hash.Write not returning an error
- rules: skip over directories under /tests/ and testutil
- rules/sdk: just aliasing an integer type prevents it from being checked
- rules/sdk: a conversion of a smaller uint type to a larger uint type MUST NEVER report an overflow/false positive
- rules/sdk: potential integer flow: do not flag any value with uint(,32,64)(len(...)) depending on bitsize because by the spec len can never be negative but even int will always fit inside uint, uint32, uint64
- all: exclude traversing the "*/testutil/*" directory from checks
coredns/coredns
4
closed
1
open
- plugin/file: zones files are opened but never closed inside fileParse
- plugin/auto: leaking (*time.Ticker) in goroutine inside setup
- plugin/forward: leaking (*time.Ticker) in goroutine inside (*Transport).connManager
- plugin/hosts: leaking (*time.Ticker) in goroutine inside periodicHostsUpdate
- coremain: unclosed caddyFile in Run
celestiaorg/nmt
2
closed
2
open
- nmt: prune's idxStart, idxEnd, maxWidth bounds aren't checked
- nmt: GetSubrootPaths: top could simply invoke make([][][]int, closingRow-startRow-1) and append once, instead of an append in a for loop
- nmt: potential overflow if the the power of 2 argument (treeDepth-i) is greater than bits.Len(math.MaxUint)
- nmt: unnecessary and expensive powerOf2 exponentiation using math.Pow then uint(float64) cast yet could simply use left bit shifts aka 1<<N
golang/go
2
open
tendermint/tendermint
1
open
CosmWasm/wasmd
1
closed
127
contributions
in private repositories
Oct 2 – Oct 26