vasanthk / react-bits

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List components #89

Open

cytrowski opened this issue Nov 12, 2017 · 0 comments

cytrowski commented Nov 12, 2017 •

edited

https://vasanthk.gitbooks.io/react-bits/patterns/32.list-components.html

I suggest putting that list item mapping function above SearchSuggestions component definition like below:

const renderSearchSuggestion = listItem => (
  <li key={listItem.id}>{listItem.name} {listItem.id}</li>
);

const SearchSuggestions = (props) => {
  return (
    <ul>
      {props.listItems.map(renderSearchSuggestion)}
    </ul>
  );
};

That way we do not create a new function each time SearchSuggestions rerenders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.