Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove flaky designation for test-worker-http2-stream-terminate #45438

Merged
merged 1 commit into from Nov 14, 2022
Merged

test: remove flaky designation for test-worker-http2-stream-terminate #45438

merged 1 commit into from Nov 14, 2022
+0 −2

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 12, 2022

Closes: #43084

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 12, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Nov 12, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47895/

@Trott
Copy link
Member Author

Trott commented Nov 12, 2022

Stress test suggests this isn't flaky anymore, so I'm going to move this out of draft mode.

https://ci.nodejs.org/job/node-stress-single-test/378/

@Trott Trott marked this pull request as ready for review Nov 12, 2022
RafaelGSS
RafaelGSS approved these changes Nov 12, 2022
View changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

LGTM.

@github-actions github-actions bot mentioned this pull request Nov 13, 2022
Open
25 tasks
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 13, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Nov 13, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47908/

lpinca
lpinca approved these changes Nov 13, 2022
View changes
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2022
@github-actions github-actions bot mentioned this pull request Nov 14, 2022
Open
25 tasks
@ywave620
Copy link
Contributor

ywave620 commented Nov 14, 2022

Should we move this test back to parallel? I checked the CI history, after this test is moved to sequential, it has reliably paased in the last few months.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit badc631 into nodejs:main Nov 14, 2022
50 checks passed
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Nov 14, 2022

Landed in badc631

@Trott Trott deleted the de-flaky branch Nov 14, 2022
This was referenced Nov 15, 2022
Open
Open
Open
Open
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@Trott @ruyadorno
test: remove flaky designation for test-worker-http2-stream-terminate
00a3b5f 
Closes: #43084
PR-URL: #45438
Fixes: #43084
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@RafaelGSS RafaelGSS

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/parallel/test-worker-http2-stream-terminate.js
5 participants
@Trott @nodejs-github-bot @ywave620 @lpinca @RafaelGSS