marktoda
Follow
Highlights
- Pro
Pinned
1,928 contributions in the last year
Less
More
Activity overview
Contributed to
Uniswap/permit2,
buttonwood-protocol/tranche,
helix-foundation/currency
and 44 other
repositories
Contribution activity
November 2022
Created 56 commits in 6 repositories
Created 3 repositories
- marktoda/awesome-huff
- marktoda/vim-huff Vim Script
- marktoda/router-sdk TypeScript
Created a pull request in Uniswap/universal-router-sdk that received 18 comments
feat: add forge tests
This commit adds forge integration tests to ensure that calldata generated by narwhal-sdk functions properly with narwhal contracts on mainnet. Not…
+237
−0
•
18
comments
Opened 44 other pull requests in 6 repositories
Uniswap/permit2
14
merged
2
closed
- fix: natspec
- Fix docs link
- feat: update permit2lib address
- fix: view warning
- feat: update salt
- feat: revert updateAllowance change
- feat: _updateApproval dont pull to stack
- feat: update solmate
- feat: add fork token tests
- feat: add salt for nice permit2 address
- feat: add permit event
- feat: peg solmate to v6
- Invariant tests
- feat: add flag for magic expiration value
- fix: improve via-ir speed
- feat: kill via-ir
Uniswap/universal-router-sdk
10
merged
Uniswap/universal-router
6
merged
2
closed
Uniswap/permit2-sdk
7
merged
1
closed
devtooligan/awesome-huff
1
merged
Uniswap/router-sdk
1
merged
Reviewed 57 pull requests in 4 repositories
Uniswap/permit2
25 pull requests
- some copy updates
- add audit
- typehash generation tests
- switch params
- tighten visibility
- add --recurse-submodules to readme clone command
- warm n fuzzy
- use struct
- add comments to errors
- Documentation
- Edit errors
-
🥕 use carrot versions for libs and interfaces🥕 - witness changes
- use from in allowance transfer details
- bitwise optimizations
- use saved val
- Domain sep return
- document magic value
- use wider nonces
- add sig length checks and support compact sigs
- add expiration to approval event
- use overloaded methods
- Edit events
- use larger return types
- match interfaces
- Some pull request reviews not shown.
Uniswap/universal-router
15 pull requests
- fix deployer
- Update Permit2 and Solmate
- The Great Rename
- LICENSE file
- feat: add multichain deployment handling
-
Separate
sliceinto the 2 usecases - For consideration: Check v2 path length explicitly
- Datatype updates
- Permit2 to use high level function calls for normal revert
- fix: permit2 integration
- forge deploy script
- Switch to json in deploy
- TRIAL: Change CONTRACT_BALANCE flag
- Combine v2 exactin and payment
- V3 callback verification
Uniswap/universal-router-sdk
10 pull requests
Uniswap/permit2-sdk
1 pull request
Created an issue in foundry-rs/forge-std that received 7 comments
Compilation still slow with via-ir
Was chatting with Georgios about this and ran some benchmarks / tests on https://github.com/uniswap/universal-router. Posting here to hopefully hel…
7
comments
Opened 8 other issues in 4 repositories
Uniswap/universal-router-sdk
2
closed
2
open
Uniswap/permit2-sdk
2
closed
Uniswap/universal-router
1
closed
foundry-rs/foundry
1
closed
14
contributions
in private repositories
Nov 2 – Nov 18