Ignore settings on Object.prototype

[EvanHahn]

Before:

app.get('hasOwnProperty');
// => [Function: hasOwnProperty]

app.enabled('hasOwnProperty');
// => true

After:

app.get('hasOwnProperty');
// => undefined

app.enabled('hasOwnProperty');
// => false

See #4802 for more details. Similar to #4803, but for Express 5.

[EvanHahn]

This makes me think: should other things, like this.cache and app.locals, use Object.create(null) too?

[dougwilson]

Yea, esp for 5, it should all be at least a null object these days.

[EvanHahn]

Would you like me to make a pull request for that?

[dougwilson]

Sure, that would be most welcome!

[EvanHahn]

Sounds good. I'll try to do that in the next month.

[EvanHahn]

Done in #4861.

[EvanHahn]

Just rebased this.

[EvanHahn]

Anything else I should do here? No rush from me, just wanna make sure I'm not blocking anything.

[dougwilson]

Hey! No, these 5.x changes are good. I'm just waiting to merge after the 4.x branch is merged in to reduce the merge conflicts is all. That should be very soon, as the 4.x changes landed are supposed to be out next week! Thank you for your hard work and discovering this issue. API is more sane now thanks to you 😊

[EvanHahn]

Great, thanks!!

If there are other things that need doing, feel free to reach out to me@evanhahn.com and I'll see if I can help.

[EvanHahn]

This has been open for over a year. No rush from me, but let me know if there's anything I can do to move this along.